Nmc 431-harmonizing of sharing permissions step 2 #28636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dress or account name of the recipient Signed-off-by: Yogesh Shejwadkar <[email protected]>
TSI-yogeshshejwadkar
force-pushed
the
NMC-431
branch
from
7cdc794
to
03c46f2
Compare
juliusknorr
added
3. to review
juliusknorr
requested review from
skjnldsv,
juliusknorr,
a team and
Pytal
and removed request for
a team
Pytal
reviewed
Sep 1, 2021
Co-authored-by: Pytal <[email protected]>
Merged
kesselb
changed the title
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
|
Superseeded by #26691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a new dropdown button under the display of the email-address or account name of the recipient
For folders
Internal user - Ready only and Allow upload and editing
External user - Read only, allow upload and editing, file drop
Share link - Read only, allow upload and editing, file drop
For files
Internal user - Read only, editing
External user - Read only ,editing
Share link - Read only ,editing
Ignored hasStatus which is having message and icon below user name or email address. We are removing this functionality in sharing 4. Also Nextcloud will change something with that function after we added this new button as discussed with Jens.
Also keeping the existing options in hamburger menu, as we will remove those in sharing 3.
Signed-off-by: Yogesh Shejwadkar [email protected]
Based on #28635